refactor: pass lighthouse accessibility audits #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jamesericdavidson
commented
Oct 25, 2024
•
jamesericdavidson
commented
- sequential headings
- css fontSize changes for h3 => h2 change? @yashmehrotra @526avijitgupta
- give names to links (screen readers)
make icon-only menu items visible to screen readers using .Identifier
|
@526avijitgupta Passes locally (desktop and mobile tests)
|
|
@526avijitgupta Did the Netlify deploy bot break when migrating the repo to an organisation? |
This was referenced Oct 25, 2024
|
@jamesericdavidson oh I just commented regarding the same thing here :D :#261 (comment) Let's verify in one of your open PRs if the deploy previews are working again 🤞 |
526avijitgupta
requested changes
Oct 27, 2024
✅ Deploy Preview for gokarna-hugo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@526avijitgupta I think review is failing because it's pointed at Deploy preview is passing:
|
526avijitgupta
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.